Restore junction schema extension compatibility - #37
Merged
Merged
Conversation
alexstandiford
marked this pull request as ready for review
September 20, 2026 15:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Restore JunctionTable's established schema-service extension points for column names and foreign keys. Keep the explicit uncached helpers and document their method-local cache bypass.
PR #34 bypasses existing overrides. The regression reproduces on release/2.2 and does not occur on 2.2.2. No current first-party schema subclass uses these overrides, so this is a public extension-compatibility defect, not a demonstrated deployed failure.
Verification
Three compatibility cases failed before the fix and pass now. They cover left and right naming overrides independently and the ordered primary-column overrides used for foreign keys.
composer install --no-interaction --prefer-distvendor/bin/phpunit: 162 tests, 483 assertions, no skipsgit diff --checkpassesThe mock-based dispatch proofs belong to the unit suite. The existing tests retain metadata, nested-junction refusal, and exception-propagation coverage. A concrete consumer fixture also proves names, identity fields, foreign keys, and repeated schema lookup through real components. It fails on the merged baseline and passes the repair. A development-only dependency on phpnomad/event supplies the real event interfaces. The old unit-test interface fallbacks are removed, with their assertions unchanged.
Siren's existing integration harness passes 38 tests and 121 assertions on locked dependencies and candidate DB/MySQL sources. It covers tenant isolation, property isolation, cache invalidation, endpoint filters, notes, and opportunity bindings. Media and Navigator Actor datastore smoke checks also pass. The final-head consumer rerun also passes. These are local consumer checks, not deployed UAT proof.
Contract and release hold
Descriptor callbacks can invoke cached methods or other side effects. The uncached helpers cannot promise a transitively cache-free descriptor. Pending phpnomad/mysql-db-integration#22 needs a compatible inspection design.
Keep this PR in draft for Alex's review. This audit authorizes no merge, release, deployment, or consumer dependency update.
GitHub's PHPUnit check passes. Repository-wide PHPStan and spellcheck remain red. Full PHPStan output matches the merged baseline's 231 diagnostics. Spellcheck reports the unchanged README and dictionary.
All 13 global review lenses and the repository-consistency review have completed. The test-tier, concrete-fixture, logging, and prose findings are resolved. The final fixture re-reviews pass. The merge rubric stops at failed hard gates, so it produces no composite score. Release and deployed UAT approval remain open.
Scope, findings, and consumer evidence: Retrospective audit: PHPNomad database consumer compatibility (Source 9959).
Retrospective: Database audit leaves two verified repair PRs for review (Journal 18775).